Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests 🥑 #562

Merged
merged 2 commits into from
Jan 19, 2021
Merged

Make tests 🥑 #562

merged 2 commits into from
Jan 19, 2021

Conversation

ChunyiLyu
Copy link
Contributor

This closes #446

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Summary Of Changes

  • Added new make targets: make chart-tests, make kubectl-plugin-tests, and make tests which runs unit, integration, system, chart, and plugin tests

  • Use these new make target in PR workflow

Additional Context

Local Testing

Please ensure you run the unit, integration and system tests before approving the PR.

To run the unit and integration tests:

$ make unit-tests integration-tests

You will need to target a k8s cluster and have the operator deployed for running the system tests.

For example, for a Kubernetes context named dev-bunny:

$ kubectx dev-bunny
$ make destroy deploy-dev
# wait for operator to be deployed
$ make system-tests

@Zerpet
Copy link
Collaborator

Zerpet commented Jan 15, 2021

The errors in the checks seem legitimate. The containers in GitHub Actions may not have all the tools we have in our dev machines.

@ChunyiLyu
Copy link
Contributor Author

@Zerpet Indeed. I'm not sure how it was passing before, but the error is because the container does not have krew installed. Going to fix it now.

Copy link
Contributor

@coro coro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray!

@ChunyiLyu ChunyiLyu merged commit 3a4a6b1 into main Jan 19, 2021
@ChunyiLyu ChunyiLyu deleted the make-tests branch January 19, 2021 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make target to run all tests
4 participants