Change default operator metrics port #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new port matches the one listed in https://github.com/prometheus/prometheus/wiki/Default-port-allocations
coro
approved these changes
Jan 14, 2021
There was a problem hiding this comment.
I approve of the change, but I think this results in a breaking change for anyone who a) consumes the operator metrics on our previously-default port 12345 and b) did not set this flag in the operator deployment spec. I'm fine with that for now as long as the next release notes mention the breaking change.
mkuratczyk
approved these changes
Jan 14, 2021
|
@coro good point, let's mention this change in the next release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new port matches the one listed in https://github.com/prometheus/prometheus/wiki/Default-port-allocations.