Make logger configurable #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, the cluster operator always used a logger dev mode, even in production. After this commit, the logger is prod mode by default. When developing locally deploying the operator using `make deploy-dev` and `make deploy-kind`, the logger will use dev mode. Futhermore, users can now configure more zap flags (see https://github.com/kubernetes-sigs/controller-runtime/blob/66537ca5b7439b06f2f3b08901640f934834c9a1/pkg/log/zap/zap.go#L227-L233) For example, they can set the log level.
ChunyiLyu
approved these changes
Jan 11, 2021
ansd
added a commit
to rabbitmq/messaging-topology-operator
that referenced
this pull request
Sep 3, 2021
Before this commit, devMode was hard-coded. Resolves #222 Same as done in rabbitmq/cluster-operator#554
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the cluster operator always used a hard-coded logger dev mode, even in production.
After this PR, the logger is prod mode by default.
This means from now on, by default, the logger will log at
Infolevel and output JSON.When developing locally deploying the operator using
make deploy-devandmake deploy-kind, the logger will use dev mode.Furthermore, users can now configure more zap flags (see https://github.com/kubernetes-sigs/controller-runtime/blob/66537ca5b7439b06f2f3b08901640f934834c9a1/pkg/log/zap/zap.go#L227-L233)
For example, they can set the log level as follows:
This resolves #551.
For more context, read https://sdk.operatorframework.io/docs/building-operators/golang/references/logging/.