Allow overriding readinessProbe and LivenessProbe #1776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There can only be 1 probe and without this change, specifying an exec readinessProbe in the spec.override would add it on top of the default TCP probe. As for livenessProbe, since there's currently no default, everything works without this change. However, we could add the default livenessProbe in the future and allowing this override doesn't break anything right now, so it's just future-proofing. Co-authored-by: joey <[email protected]>
Zerpet
approved these changes
Nov 22, 2024
|
Yup, same. But this is something can fix separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There can only be 1 probe and without this change, specifying an exec readinessProbe in the spec.override would add it on top of the default TCP probe.
As for livenessProbe, since there's currently no default, everything works without this change. However, we could add the default livenessProbe in the future and allowing this override doesn't break anything right now, so it's just future-proofing.
This PR supersedes #1775 which didn't contain tests
This closes #1698