Update condition to enable Web MQTT/STOMP TLS ports #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a condition that CA bundle secret name must be provided. This was encapsulated in the function `MutualTLSEnabled()`. After this commit, the only condition to enable MQTT/STOMP TLS ports is to have a secret name in the tls attribute of the spec.
MirahImage
approved these changes
Sep 26, 2024
mkuratczyk
approved these changes
Sep 26, 2024
Zerpet
changed the title
Zerpet
added a commit
that referenced
this pull request
Oct 11, 2024
This test became ineffective after #1735. We want to enable Web MQTT/STOMP TLS regardless of whether a CA bundle certificate is provided. This test was asserting that we enable web stomp/mqqt tls when the CA bundle is set; however, by not setting the CA bundle, the test passes anyway. This is not correct, making the test ineffective.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1677
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
There was a condition that CA bundle secret name must be provided. This
was encapsulated in the function
MutualTLSEnabled(). After thiscommit, the only condition to enable Web MQTT/STOMP TLS ports is to have a
secret name in the tls attribute of the spec.
Local Testing
Please ensure you run the unit, integration and system tests before approving the PR.
To run the unit and integration tests:
You will need to target a k8s cluster and have the operator deployed for running the system tests.
For example, for a Kubernetes context named
dev-bunny: