-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add connection_string secret to default_user secret #1721
Conversation
11a25b0
to
b14f82d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this contribution. I like this idea. I left some cosmetic suggestions.
8303468
to
99f123a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is looking better 👍 I left two suggestions before approving this PR.
Committed your changes :) |
Hey @Zerpet |
I approved the PR ✅ I'll merge after CI passes. We released 2.10.0 last week, and it is a bit soon to release another version. We tend to wait for 1 month between minor releases. Plus we have some dependabot PRs that need manual intervention. If you want to use these changes right away, I'd recommend that you build own "snapshot" version from Lines 207 to 210 in 86e948e
You can build the operator locally, for example, with:
You will have to push the image then with |
Great, I will build an image myself for the time being. |
This closes #1722
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
Added a new key
connection_string
to the default_user secret with a formatted connection_string.