Disable ANONYMOUS login #1705
Merged
Disable ANONYMOUS login #1705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See rabbitmq/rabbitmq-server#11999 for full context. Starting with RabbitMQ 4.0, anonymous login should be disabled in production. `anonymous_login_user` and `anonymous_login_pass` both default to `guest` in RabbitMQ 4.0. The rabbitmq/cluster-operator complies already with best practices by provisioning a new `default_user` and `default_pass` instead of using RabbitMQ's default `guest` user. Instead of having RabbitMQ advertise the ANONYMOUS mechanism, this commit disables anonymous logins. Because `anonymous_login_user` is a new RabbitMQ 4.0 `rabbitmq.conf` setting and the cluster-operator doesn't know what RabbitMQ version it deploys and setting `rabbitmq.conf` key `anonymous_login_user` in RabbitMQ 3.13 would make booting RabbitMQ fail, this commit modifies the `auth_mechanisms.*` settings in `rabbitmq.conf`: If the user provided a conscious choice on what `auth_mechanisms` RabbitMQ should advertise, this configuration will be respected. If the user did not configure `auth_mechanisms`, the cluster-operator will disable ANONYMOUS logins by setting only: ``` auth_mechanisms.1 = PLAIN auth_mechanisms.2 = AMQPLAIN ```
|
Note to reviewers: You could deploy different configurations in |
Zerpet
reviewed
Aug 19, 2024
Zerpet
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rabbitmq/rabbitmq-server#11999 for full context.
Starting with RabbitMQ 4.0, anonymous login should be disabled in production.
anonymous_login_userandanonymous_login_passboth default toguestin RabbitMQ 4.0. The rabbitmq/cluster-operator complies already with best practices by provisioning a newdefault_useranddefault_passinstead of using RabbitMQ's defaultguestuser.Instead of having RabbitMQ advertise the ANONYMOUS mechanism, this commit disables anonymous logins.
Because
anonymous_login_useris a new RabbitMQ 4.0rabbitmq.confsetting and the cluster-operator doesn't know what RabbitMQ version it deploys and settingrabbitmq.confkeyanonymous_login_userin RabbitMQ 3.13 would make booting RabbitMQ fail, this commit modifies theauth_mechanisms.*settings inrabbitmq.conf:If the user provided a conscious choice on what
auth_mechanismsRabbitMQ should advertise, this configuration will be respected. If the user did not configureauth_mechanisms, the cluster-operator will disable ANONYMOUS logins by setting only: