Add rabbitmq.com/disable-default-topology-spread-constraints annotation #1694
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the annotation rabbitmq.com/disable-default-topology-spread-constraints is set to "true", the default topologySpreadConstraints based on label topology.kubernetes.io/zone is omitted.
As @Zerpet suggested in issue #1687, I added the annotation to skip the default topology constraint configuration because the override was not working as expected ( #1690 ), and @mkuratczyk was not satisfied with the behavior.
This closes #1687
Note to reviewers: Remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
When a user adds the annotation
rabbitmq.com/disable-default-topology-spread-constraints: "true"
in their RabbitMQCluster custom resource, the default topology spread constraint is omitted.Additional Context
Local Testing
Please ensure you run the unit, integration and system tests before approving the PR.
To run the unit and integration tests:
You will need to target a k8s cluster and have the operator deployed for running the system tests.
For example, for a Kubernetes context named
dev-bunny
: