Filter what objects we cache from the API #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkuratczyk
force-pushed
the
reduce-memory-usage
branch
2 times, most recently
from
46ff530 to
d970cf8
Compare
Zerpet
approved these changes
Jan 31, 2024
mkuratczyk
force-pushed
the
reduce-memory-usage
branch
from
d970cf8 to
5157a08
Compare
With 10000 small ConfigMaps and 10000 Services in a cluster, that have nothing to do with RabbitMQ, here is the before: ``` (pprof) top Showing nodes accounting for 47.56MB, 93.15% of 51.06MB total ``` and after: ``` (pprof) top Showing nodes accounting for 5255.83kB, 100% of 5255.83kB total ```
Now that we cache only specific objects from the API, we don't see TLS secrets that don't have the "app.kubernetes.io/part-of=rabbitmq" label. To check if the desired secrets exist, use the APIReader which checks the API directly.
mkuratczyk
force-pushed
the
reduce-memory-usage
branch
from
cd3f791 to
da9e272
Compare
The Operator part is not very interesting when it is "unchanged" The error part is the most interesting, but wasn't present at all
Zerpet
reviewed
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With 10000 edit ConfigMaps and 10000 Services in a cluster, that have nothing to do with RabbitMQ, here is the before:
and after:
Basically, memory usage should only depend on the number of RabbitMQ clusters currently deployed, not on the number and size of any unrelated objects.
This closes #1537