Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move verbose log lines to debug #1269

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Move verbose log lines to debug #1269

merged 2 commits into from
Feb 22, 2023

Conversation

ChunyiLyu
Copy link
Contributor

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Summary Of Changes

  • Update generated CRD
  • log cluster spec at debug instead of info
  • log message about requeue request to enable plugin at debug instead of info
  • log successfully queue rebalance like other cli command

'Start reconciling' log which used to contain .spec now looks like
2023-02-21T17:35:40Z INFO Start reconciling {"controller": "rabbitmqcluster", "controllerGroup": "rabbitmq.com", "controllerKind": "RabbitmqCluster", "RabbitmqCluster": {"name":"sample","namespace":"rabbitmq-system"}, "namespace": "rabbitmq-system", "name": "sample", "reconcileID": "b8013f6d-40a3-45db-9b57-77e21e56d2a2"}

Additional Context

Local Testing

- log cluster spec at debug instead of info
- log message about requeue request to enable plugin at debug
- log successfully queue rebalance like other cli command
Copy link
Member

@MirahImage MirahImage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I was undecided at first whether the requeue bit should be debug, but after thinking about it more, it's definitely an internal detail and therefore debug level makes sense.

@ChunyiLyu ChunyiLyu merged commit 8a27f40 into main Feb 22, 2023
@ChunyiLyu ChunyiLyu deleted the log branch February 22, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants