Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reverting pr_1241 #1243

Merged
merged 1 commit into from
Jan 30, 2023
Merged

reverting pr_1241 #1243

merged 1 commit into from
Jan 30, 2023

Conversation

DanielePalaia
Copy link
Contributor

@DanielePalaia DanielePalaia commented Jan 30, 2023 •
edited
Loading

This closes #

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Summary Of Changes

Reverting PR #1241 for testing

Additional Context

Local Testing

Please ensure you run the unit, integration and system tests before approving the PR.

To run the unit and integration tests:

$ make unit-tests integration-tests

You will need to target a k8s cluster and have the operator deployed for running the system tests.

For example, for a Kubernetes context named dev-bunny:

$ kubectx dev-bunny
$ make destroy deploy-dev
# wait for operator to be deployed
$ make system-tests

@DanielePalaia DanielePalaia merged commit e66898b into main Jan 30, 2023
@DanielePalaia DanielePalaia deleted the reverting_1241 branch January 30, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DanielePalaia