-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating Concourse CI pipelines to GH Actions #1208
Conversation
This reverts commit 91730ea.
Based upon sequential changes to the same file you could squash the following sets of commits. Makefile changes: [c8aa3a1 b490b8c] Makefile Changes Round 2: [afb8bf2 1201371] Build-test-publish Round 2 [e750037 e7b1016] Build-test-publish Round 3 [dbef9a3 70a9428] Build-test-publish Final Round! [40ab6c1 f06842d] I can't say to much about the github actions changes themselves, will keep an eye on them as they run :) Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments. Looks good!
env: | ||
GO_VERSION: ~1.19 | ||
K8S_VERSION: v1.24.1 | ||
BASELINE_UPGRADE_VERSION: v1.12.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 1.12.0
as the baseline version? Do we plan to bump this version with new minors released in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The baseline is the most recent release that contained a change that caused a rolling restart. We discussed the possibility of limiting these changes to only major version updates instead, but for now this replicates the behaviour of the hush house CI.
This closes #1202
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
Additional Context
The pipeline now runs, on PRs:
On pushes to main:
rabbitmqoperator/cluster-operator
with a tag of the SHA256 andedge
), and a manifest referencing that OCIOn creation of a tag in the repo:
latest
if the latest version, and the semver version of the releaseN.B.: This PR removes the use of the rabbitmqoperator/cluster-operator-dev image, as it's now functionally replaced by the regular image with a SHA tag.
Local Testing
Please ensure you run the unit, integration and system tests before approving the PR.
To run the unit and integration tests:
You will need to target a k8s cluster and have the operator deployed for running the system tests.
For example, for a Kubernetes context named
dev-bunny
: