Add Aggregating ClusterRole for Service Bindings #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This automatically sets up the RBAC required to work with implementors of the Service Binding specification. As per the spec recommendation: > Cluster operators and CRD authors SHOULD opt-in resources to expose provisioned services by defining a ClusterRole with a label matching servicebinding.io/controller=true From https://servicebinding.io/spec/core/1.0.0/#considerations-for-role-based-access-control-rbac
Samze
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This automatically sets up the RBAC required to work with implementors of the Service Binding specification.
As per the spec recommendation:
This closes #1149
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
Adds a new ClusterRole with the appropriate
servicebinding.io/controller=truelabel. The defaultkustomizeconfiguration appendsrabbitmq-cluster-to the resource name.