-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop testing rmq 3.8 #1110
Merged
Merged
Stop testing rmq 3.8 #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove 3.8.8 github action tests - update README to say the Operator supports 3.9 onwards
ablease
approved these changes
Aug 11, 2022
coro
approved these changes
Aug 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's also some tests that get run per-commit on this repo in our Concourse; looks like those are out of date too.
ansd
added a commit
that referenced
this pull request
Aug 15, 2022
Since we bumped the minimum supported RabbitMQ version to v3.9.0 in #1110, we can use the CLI command `rabbitmqctl enable_feature_flag all` introduced in rabbitmq/rabbitmq-server@ce65586.
ansd
added a commit
that referenced
this pull request
Aug 15, 2022
Since we bumped the minimum supported RabbitMQ version to v3.9.0 in #1110, we can delete the deprecated `cluster_formation.randomized_startup_delay_range` configurations. See rabbitmq/rabbitmq-server#3075. Prior to this commit, the RabbitMQ logs contained the following warning: ``` 2022-08-15 08:18:03.870480+00:00 [warn] <0.130.0> cluster_formation.randomized_startup_delay_range.min and cluster_formation.randomized_startup_delay_range.max are deprecated ```
ansd
added a commit
that referenced
this pull request
Aug 15, 2022
Follow up of #1110: The new minimum supported version is 3.9.0. Therefore, we should test against that version to make sure the cluster-operator is compatible with the minimum supported version.
ansd
added a commit
that referenced
this pull request
Aug 15, 2022
Since we bumped the minimum supported RabbitMQ version to v3.9.0 in #1110, we can use the CLI command `rabbitmqctl enable_feature_flag all` introduced in rabbitmq/rabbitmq-server@ce65586.
ansd
added a commit
that referenced
this pull request
Aug 15, 2022
Since we bumped the minimum supported RabbitMQ version to v3.9.0 in #1110, we can delete the deprecated `cluster_formation.randomized_startup_delay_range` configurations. See rabbitmq/rabbitmq-server#3075. Prior to this commit, the RabbitMQ logs contained the following warning: ``` 2022-08-15 08:18:03.870480+00:00 [warn] <0.130.0> cluster_formation.randomized_startup_delay_range.min and cluster_formation.randomized_startup_delay_range.max are deprecated ```
ansd
added a commit
that referenced
this pull request
Aug 15, 2022
Follow up of #1110: The new minimum supported version is 3.9.0. Therefore, we should test against that version to make sure the cluster-operator is compatible with the minimum supported version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
Stop testing rmq 3.8 as it has reached end of support
Additional Context