Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to set up tls verify for prometheus servicemonitor #1037

Merged
merged 1 commit into from
May 16, 2022

Conversation

ChunyiLyu
Copy link
Contributor

This closes #1007

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Summary Of Changes

Instead of adding a new example yaml, the tls section is added as comment section since the rest of the configuration is the same.

Copy link
Contributor

@DanielePalaia DanielePalaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ChunyiLyu ChunyiLyu merged commit 019bc24 into main May 16, 2022
@ChunyiLyu ChunyiLyu deleted the service-monitor-tls branch May 16, 2022 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate TLS cert when scraping RabbitMQ metrics
2 participants