Vault svc reference #1031
Merged
Vault svc reference #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the function updates statusConditions instead of the entire object status
- user is used; this is because downstream, topology operator in this case, may rely on the rabbitmqcluster.status for certain information. topology operator relies on the service reference to get the name of the ingress service to be able to connect to a given rabbitmqcluster
ChunyiLyu
force-pushed
the
vault-svc-reference
branch
from
3d4c11e to
5042a82
Compare
coro
approved these changes
May 12, 2022
Zerpet
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1030
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
in this case, may rely on the rabbitmqcluster.status for certain information. topology operator relies on the service
reference to get the name of the ingress service to be able to connect to a given rabbitmqcluster
of the entire object status
Additional Context
Status tested in integration test.
Local Testing