fix: remove protocol fee split

rabbitholegg · Jun 28, 2024 · c9330bc · c9330bc
1 parent 9927200
commit c9330bc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/contracts/Quest.sol b/contracts/Quest.sol
@@ -163,7 +163,7 @@ contract Quest is ReentrancyGuardUpgradeable, PausableUpgradeable, Ownable, IQue
         protocolFeeRecipient.safeTransferETH(protocolPayout);
 
         // transfer reward tokens
-        uint256 protocolFeeForRecipient = this.protocolFee() / 2;
+        uint256 protocolFeeForRecipient = this.protocolFee();
         rewardToken.safeTransfer(protocolFeeRecipient, protocolFeeForRecipient);
 
         uint256 remainingBalanceForOwner = rewardToken.balanceOf(address(this)) - (referralClaimTotal - totalReferralsFeesClaimed);

diff --git a/test/Quest.t.sol b/test/Quest.t.sol
@@ -246,7 +246,7 @@ contract TestQuest is Test, TestUtils, Errors, Events {
         // simulate ETH from TOTAL_PARTICIPANTS claims
         vm.deal(address(quest), (CLAIM_FEE * TOTAL_PARTICIPANTS * 2) / 3);
 
-        uint256 totalFees = calculateTotalProtocolFees(TOTAL_PARTICIPANTS, REWARD_AMOUNT_IN_WEI, QUEST_FEE) / 2;
+        uint256 totalFees = calculateTotalProtocolFees(TOTAL_PARTICIPANTS, REWARD_AMOUNT_IN_WEI, QUEST_FEE);
         uint256 questBalance = SampleERC20(rewardTokenAddress).balanceOf(address(quest));
         uint256 questBalanceMinusFees = questBalance - totalFees;
 
@@ -396,7 +396,7 @@ contract TestQuest is Test, TestUtils, Errors, Events {
 
         assertEq(
             protocolFeeRecipientBalance,
-            quest.protocolFee() / 2,
+            quest.protocolFee(),
             "Protocol fee recipient should get their share of the rewards"
         );
 
@@ -497,7 +497,7 @@ contract TestQuest is Test, TestUtils, Errors, Events {
 
         assertEq(
             protocolFeeRecipientBalance,
-            quest.protocolFee() / 2,
+            quest.protocolFee(),
             "Protocol fee recipient should get their share of the rewards"
         );