Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify __str__ for BaseSequence #7

Merged
merged 23 commits into from
Feb 26, 2024
Merged

Conversation

sinhaharsh
Copy link
Collaborator

Prints only non-empty parameters in the sequence.

@raamana
Copy link
Owner

raamana commented Feb 5, 2024

did you test with a BIDS dataset locally, in dev mode?

@sinhaharsh sinhaharsh marked this pull request as draft February 6, 2024 19:56
@sinhaharsh sinhaharsh marked this pull request as ready for review February 21, 2024 19:34
@sinhaharsh sinhaharsh marked this pull request as draft February 21, 2024 19:36
Deprecate requirements_dev.txt
Add comments about parameter arguments
Cast string to Path before using .exists
@raamana
Copy link
Owner

raamana commented Feb 22, 2024

github says this is a draft PR - let me when you are ready

@sinhaharsh sinhaharsh marked this pull request as ready for review February 23, 2024 16:36
@sinhaharsh
Copy link
Collaborator Author

This PR is in a much better shape now. I have tested it with multiple BIDS datasets.

@raamana raamana merged commit 36449f7 into raamana:master Feb 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants