argument checks for all user facing functions #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync up dev branch to main to avoid potential merge conflicts later
|
Thanks Egor, will take a look later today. |
Robinlovelace
approved these changes
Dec 13, 2024
| @@ -40,26 +40,44 @@ spod_convert <- function( | |||
| data_dir = spod_get_data_dir(), | |||
| quiet = FALSE, | |||
| max_mem_gb = max(4, spod_available_ram() - 4), | |||
| max_n_cpu = parallelly::availableCores() - 1, | |||
| max_n_cpu = max(1, parallelly::availableCores() - 1), | |||
| zones <- match.arg(zones) | ||
|
|
||
| # Validate inputs | ||
| checkmate::assert_choice(type, choices = c("od", "origin-destination", "os", "overnight_stays", "nt", "number_of_trips")) |
There was a problem hiding this comment.
Great to see all these additional checks.
| @@ -481,7 +486,7 @@ entry-spacing="0"> | |||
|
|
|||
| Lovelace, Robin, and Malcolm Morgan. 2024. “Od: Manipulate and Map | |||
| Origin-Destination Data,” August. | |||
| <https://cran.r-project.org/web/packages/od/od.pdf>. | |||
| <https://doi.org/10.32614/CRAN.package.od>. | |||
e-kotov
deleted the
23-improve-type-safety-with-rlang-or-assertthat-or-checkmate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a final functionality and documentation focussed PR before I reshuffle the functions into separate files for a final cleanup and submit to CRAN. We still have until 23 Dec to submit and their current newbies queue is unusually small (just over 10 packages, see https://nx10.github.io/cransubs/ or https://r-hub.github.io/cransays/articles/dashboard.html ).