Implements a cache method so that a file is not downloaded if it alre…

…ady exists in tempdir
rOpenSpain · May 30, 2024 · 4aaecd4 · 4aaecd4
1 parent 52407c3
commit 4aaecd4
Show file tree

Hide file tree

Showing 8 changed files with 24 additions and 16 deletions.
diff --git a/R/candidatos_nosenado.R b/R/candidatos_nosenado.R
@@ -24,7 +24,9 @@ candidatos_nosenado <- function(tipo, anno, mes) {
   url <- paste0(urlbase, tipo, anno, mes, "_MUNI", ".zip")
   ### Descargo el fichero zip en un directorio temporal y lo descomprimo
   tempd <- tempdir(check = TRUE)
-  temp <- tempfile(tmpdir = tempd, fileext = ".zip")
+  filename <- gsub(".+/", "", url)
+  temp <- file.path(tempd, filename)
+  tempd <- file.path(tempd, gsub(".zip", "", filename))
   download_bin(url, temp)
   unzip(temp, overwrite = TRUE, exdir = tempd)
 

diff --git a/R/cleanup.R b/R/cleanup.R
@@ -8,6 +8,6 @@
 #' @keywords internal
 #'
 cleanup <- function(files, dirs) {
-  file.remove(files)
+  # file.remove(files)
   unlink(dirs, recursive=TRUE)
 }
diff --git a/R/download_bin.R b/R/download_bin.R
@@ -15,7 +15,14 @@ download_bin <- function(url, tempfile) {
     "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:98.0)",
     "Gecko/20100101 Firefox/98.0"
   )
-  message("Downloading ", url)
-  res <- GET(url, add_headers(`User-Agent` = UA, Connection = "keep-alive"))
-  writeBin(res$content, tempfile)
+
+  if(file.exists(tempfile)) {
+    message("File already exists, skipping download")
+  } else {
+    message("Downloading ", url)
+    res <- GET(url, add_headers(`User-Agent` = UA, Connection = "keep-alive"))
+    writeBin(res$content, tempfile)
+  }
+
+
 }
diff --git a/R/mesas.R b/R/mesas.R
@@ -27,8 +27,8 @@ mesas <- function(tipo_eleccion, anno, mes) {
   ### Descargo el fichero zip en un directorio temporal y lo descomprimo
   tempd <- tempdir(check = TRUE)
   filename <- gsub(".+/", "", url)
-  temp <- file.path(tempd, filename, fsep = "\\")
-  tempd <- paste0(tempd, "\\", gsub(".zip", "", filename))
+  temp <- file.path(tempd, filename)
+  tempd <- file.path(tempd, gsub(".zip", "", filename))
   download_bin(url, temp)
   unzip(temp, overwrite = TRUE, exdir = tempd)
 

diff --git a/R/muni.R b/R/muni.R
@@ -28,10 +28,9 @@ municipios <- function(tipo_eleccion, anno, mes, distritos = FALSE) {
   ### Descargo el fichero zip en un directorio temporal y lo descomprimo
   tempd <- tempdir(check = TRUE)
   filename <- gsub(".+/", "", url)
-  temp <- file.path(tempd, filename, fsep = "\\")
-  tempd <- paste0(tempd, "\\", gsub(".zip", "", filename))
+  temp <- file.path(tempd, filename)
+  tempd <- file.path(tempd, gsub(".zip", "", filename))
   download_bin(url, temp)
-
   unzip(temp, overwrite = TRUE, exdir = tempd)
 
   ### Construyo las rutas a los ficheros DAT necesarios

diff --git a/R/provincias.R b/R/provincias.R
@@ -27,8 +27,8 @@ provincias <- function(tipo_eleccion, anno, mes) {
   ### Descargo el fichero zip en un directorio temporal y lo descomprimo
   tempd <- tempdir(check = TRUE)
   filename <- gsub(".+/", "", url)
-  temp <- file.path(tempd, filename, fsep = "\\")
-  tempd <- paste0(tempd, "\\", gsub(".zip", "", filename))
+  temp <- file.path(tempd, filename)
+  tempd <- file.path(tempd, gsub(".zip", "", filename))
   download_bin(url, temp)
   unzip(temp, overwrite = TRUE, exdir = tempd)
 

diff --git a/R/senado_mesas.R b/R/senado_mesas.R
@@ -26,8 +26,8 @@ senado_mesas <- function(anno, mes) {
   ### Descargo el fichero zip en un directorio temporal y lo descomprimo
   tempd <- tempdir(check = TRUE)
   filename <- gsub(".+/", "", url)
-  temp <- file.path(tempd, filename, fsep = "\\")
-  tempd <- paste0(tempd, "\\", gsub(".zip", "", filename))
+  temp <- file.path(tempd, filename)
+  tempd <- file.path(tempd, gsub(".zip", "", filename))
   download_bin(url, temp)
   unzip(temp, overwrite = TRUE, exdir = tempd)
 

diff --git a/R/senado_municipios.R b/R/senado_municipios.R
@@ -26,8 +26,8 @@ senado_municipios <- function(anno, mes) {
   ### Descargo el fichero zip en un directorio temporal y lo descomprimo
   tempd <- tempdir(check = TRUE)
   filename <- gsub(".+/", "", url)
-  temp <- file.path(tempd, filename, fsep = "\\")
-  tempd <- paste0(tempd, "\\", gsub(".zip", "", filename))
+  temp <- file.path(tempd, filename)
+  tempd <- file.path(tempd, gsub(".zip", "", filename))
   download_bin(url, temp)
   unzip(temp, overwrite = TRUE, exdir = tempd)