build(deps): switch to crates.io dependencies #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterwht
approved these changes
Mar 23, 2024
evilrobot-01
force-pushed
the
frank/build-switch-crates-io-deps
branch
from
74e031d to
17dab67
Compare
Daanvdplas
approved these changes
Mar 25, 2024
There are crates release branches in the SDK with version numbers, so it's done manually by looking at the versions there. Hope to update pop with some utility which automates this, at least from the manifest perspective.
|
evilrobot-01
force-pushed
the
frank/build-switch-crates-io-deps
branch
from
17dab67 to
32844f6
Compare
al3mart
approved these changes
Mar 27, 2024
Workaround due to issue with newer patch versions including additional benchmark, incompatible with asset-hub-rococo-runtime v0.12.
|
No easy rebase due to squash, cherry picking into a new branch from main, will test and then push. |
evilrobot-01
force-pushed
the
frank/build-switch-crates-io-deps
branch
from
32844f6 to
5578782
Compare
peterwht
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to crates.io dependencies.