-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: network token enforcement #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Should we add testing the integrations in the CI or is that too much?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We will probably want to introduce some tests later on for allowing users to withdraw tokens back to the relay chain
Reserve transfer to Pop Network script tracker: #47 |
Already exists: pop-node/integration-tests/src/lib.rs Line 325 in 9102be2
|
Ah nice. Missed that one and thought we were testing transfer to SA account. |
Already included - see https://github.com/r0gue-io/pop-node/actions/runs/8383155297/job/22958325605: |
Network now launches with zero total issuance, requiring a reserve transfer from the relay to get started. This will be automated with a pop up feature, but for now one can reserve transfer from relay to Pop with the following encoded calls:
0x630804000100098e0400010100d43593c715fdd31c61141abd04a99fd6822c8558854ccde39a5684e7a56da27d04040000000b00407a10f35a0000000000
0x630804000100098e04000101008eaf04151687736326c9fea17e25fc5287613693c912909cb226aa4794f26a4804040000000b00407a10f35a0000000000
Commits:
balances::force*
calls to prevent minting of native token, ensuring network can only be funded from relay token