-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: token name & symbol return Option
#312
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #312 +/- ##
==========================================
+ Coverage 51.47% 51.50% +0.02%
==========================================
Files 48 48
Lines 4894 4897 +3
Branches 4894 4897 +3
==========================================
+ Hits 2519 2522 +3
Misses 2326 2326
Partials 49 49
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpitcks but not very important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, made some minor suggestions for improving the tests which are quick and easy to implement if you so choose.
The psp22 standard returns an
Option<String>
. In stead of having the contract needing to add additional logic, we handle it in the pallet.