Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to stable2412 #53

Merged
merged 8 commits into from
Jan 23, 2025
Merged

chore: upgrade to stable2412 #53

merged 8 commits into from
Jan 23, 2025

Conversation

f-gate
Copy link
Collaborator

@f-gate f-gate commented Jan 21, 2025

@f-gate f-gate changed the title Upgrade 2412 chore: Upgrade 2412 Jan 21, 2025
@chungquantin chungquantin changed the title chore: Upgrade 2412 chore: upgrade to stable2412 Jan 21, 2025
Copy link
Collaborator

@chungquantin chungquantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far! However, seems like there are missing changes for:

Cargo.toml Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
runtime/src/genesis_config_presets.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@peterwht peterwht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. Almost ready to approve!

At this line: https://github.com/r0gue-io/base-parachain/blob/main/runtime/src/apis.rs#L245

There is a deprecated return type. It shows when built with --features runtime-benchmarks

warning: use of deprecated type alias `sp_runtime::RuntimeString`: Use String or Cow<'static, str> instead
   --> runtime/src/apis.rs:245:74
    |
245 |         ) -> Result<Vec<frame_benchmarking::BenchmarkBatch>, sp_runtime::RuntimeString> {

Cargo.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@AlexD10S AlexD10S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I see that Tin and Peter's feedback has been addressed. I have nothing else to add.

Copy link
Contributor

@peterwht peterwht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Felix

@AlexD10S AlexD10S merged commit 82741b4 into r0gue-io:main Jan 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants