-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to stable2412 #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great so far! However, seems like there are missing changes for:
Transaction Extension
(introduced in this commit).- And a refactor in the node
command.rs
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job. Almost ready to approve!
At this line: https://github.com/r0gue-io/base-parachain/blob/main/runtime/src/apis.rs#L245
There is a deprecated return type. It shows when built with --features runtime-benchmarks
warning: use of deprecated type alias `sp_runtime::RuntimeString`: Use String or Cow<'static, str> instead
--> runtime/src/apis.rs:245:74
|
245 | ) -> Result<Vec<frame_benchmarking::BenchmarkBatch>, sp_runtime::RuntimeString> {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! I see that Tin and Peter's feedback has been addressed. I have nothing else to add.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks Felix
ref: https://app.shortcut.com/r0gue/story/1934/chore-upgrade-base-parachain-to-stable2412
[sc-1934]