Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up documentation, configuration, and CI following S2 version update #263

Merged
merged 21 commits into from
Oct 11, 2024

Conversation

paleolimbot
Copy link
Collaborator

@paleolimbot paleolimbot commented Oct 10, 2024

This PR:

  • Cleans up the configure script to remove pathways that are no longer supported. Basically, pkg-config is required now (because resolving the linking order of the absl static libraries is absolutely insane without it). It also improves the error messages for various types of failures, although probably not all of them.
  • Adds Docker images and a docker compose setup to ensure that the compile + test works based on the install instructions for various linux setups. Notably, it makes sure that it effectively uses system Abseil where available (e.g., debian testing, fedora >= 39, alpine), and that it does not use system Abseil of an insufficient version (e.g., all current Ubuntu, Fedora 36).
  • Improves the CI jobs to effectively use system Abseil where possible (basically just MacOS). I added a bit of a "pre-check" job that, if it fails, will prevent the other long-running jobs from kicking off. This should give relatively rapid feedback for the feature development + test cycle (and not significantly delay changes related to the build).

This PR does not fix R 4.0 and R 4.1 on Windows yet (battle for another day).

@paleolimbot paleolimbot marked this pull request as ready for review October 10, 2024 20:35
@paleolimbot paleolimbot merged commit b495b0d into main Oct 11, 2024
10 checks passed
@paleolimbot paleolimbot deleted the test-absl-scenarios branch October 11, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant