Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of encoding argument #219

Merged
merged 5 commits into from
Sep 16, 2024
Merged

get rid of encoding argument #219

merged 5 commits into from
Sep 16, 2024

Conversation

jannes-m
Copy link
Collaborator

@jannes-m jannes-m commented Sep 5, 2024

This addresses and solves #218.
qgis_run() calls processx::run().
In the documentation of the latter it says on the encoding argument:

The encoding to assume for stdout and stderr. By default the encoding of the current locale is used. Note that processx always reencodes the output of both streams in UTF-8 currently.

Hence, it seems there is no need to explicitly set the encoding.
What do you think @florisvdh?
Or am I overlooking any unwanted side-effects?
FYI: devtools::check() also runs successfully with this modification.

@florisvdh
Copy link
Member

florisvdh commented Sep 6, 2024

Thanks @jannes-m for addressing this. We should give this a try; if it poses no further issues or side effects this would definitely be a simplification on the {qgisprocess} side. For consistency, I propose to add PR #220 in this PR.

I could not find any consequences for now; based on r-lib/processx#265 and r-lib/processx#299 I assume indeed this should work.

@florisvdh florisvdh merged commit 17d7b66 into main Sep 16, 2024
17 checks passed
@florisvdh florisvdh deleted the bug_locale branch September 16, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants