Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow editor options with editFeatures/drawFeatures #92

Open
timelyportfolio opened this issue Feb 2, 2019 · 4 comments
Open

Allow editor options with editFeatures/drawFeatures #92

timelyportfolio opened this issue Feb 2, 2019 · 4 comments

Comments

@timelyportfolio
Copy link
Contributor

@tim-salabim brings up a good point in email and #90 (comment) that currently there is no way to provide editor options in editFeatures or drawFeatures. This likely most affects editor = "leafpm" since a user might want to change snappable, snapDistance, and allowSelfIntersection. I'd like to target this for next release.

@tim-salabim
Copy link
Member

Next release sounds good. Let's draw the RConsortium project to a close first

@lbusett
Copy link
Contributor

lbusett commented Feb 4, 2019

I think being able to tweak also the "appearance" of the editFeatures map would be good, if possibile (e.g., stroke width and color, polygon transparency, shape/size of vertexes while editing....).

@JoshOBrien
Copy link
Contributor

JoshOBrien commented Apr 12, 2019

I just went ahead and modified editFeatures() to take and process additional arguments pmToolbarOpts, pmDrawOpts, pmEditOpts, and pmCutOpts, which it then passes on to the corresponding leafpm functions. Would this be welcome as a pull request, and if so, should I submit that and then link to this Issue in the pull request message?

@tim-salabim
Copy link
Member

Yes, a PR would be great. You can simply put someting like " addresses #92" in your commit message to link the PR to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants