Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust for latest roxygen2 update #32

Merged
merged 1 commit into from
Nov 10, 2018
Merged

Adjust for latest roxygen2 update #32

merged 1 commit into from
Nov 10, 2018

Conversation

pat-s
Copy link
Member

@pat-s pat-s commented Nov 10, 2018

@edzer edzer merged commit 1ddfc0c into r-spatial:master Nov 10, 2018
tic.R Show resolved Hide resolved
@edzer
Copy link
Member

edzer commented Feb 8, 2019

@pat-s any idea what is going on here?

@edzer
Copy link
Member

edzer commented Apr 8, 2019

@pat-s any idea what is going on here: https://travis-ci.org/r-spatial/lwgeom/jobs/516967717 ?

@krlmlr
Copy link

krlmlr commented Apr 8, 2019

Looks like a {pkgdown} error to me. Can you build the pkgdown site locally?

@edzer
Copy link
Member

edzer commented Apr 8, 2019

Indeed! It stops at

> pkgdown::build_home(quiet = FALSE)
── Building home ───────────────────────────────────────────────────────────────
Error in xml2::xml_contents(heading)[[1]] : subscript out of bounds
> traceback()
5: xml2::xml_add_sibling(xml2::xml_contents(heading)[[1]], "a", 
       href = paste0("#", anchor[[i]]), class = "anchor", .where = "before")
4: tweak_anchors(xml, only_contents = FALSE)
3: markdown(src_path)
2: build_home_index(pkg, quiet = quiet)
1: pkgdown::build_home(quiet = FALSE)

but there I get lost. Any suggestion?

@pat-s
Copy link
Member Author

pat-s commented Apr 8, 2019

The error appeared after f016739 which introduced the roxygen2 v6.1.1 Note.

RoxygenNote: 6.1.1 should not be a problem actually and pkgdown v1.3.0 is also fine.

The log complains about the authors field. Maybe caused by person("liblwgeom developers", role = "cph"))? However, this did not change recently and pkgdown built fine before.

I'll try some changes, maybe we need again to chain devtools::document() as we do in other packages since roxygen2 >= 6.1.1.

@pat-s
Copy link
Member Author

pat-s commented Apr 8, 2019

Ok, found the issue.

After a fresh clone of the repo, README.md looks like this:

screenshot_2019-04-08_21-30-20_348594184

Note the missing title in the last Header2. This causes the error shown above.
The README on GH looks fine so something seems to corrupt the cloning process.
Since Travis also just clones the repo, the error is also occurring there.

So it is unrelated to tic and looks a bit mysterious right now.

@edzer
Copy link
Member

edzer commented Apr 8, 2019

Thank you so much!

edzer added a commit that referenced this pull request Apr 8, 2019
@pat-s
Copy link
Member Author

pat-s commented Apr 8, 2019

You're welcome.
Any idea about the GH <-> local mismatch?

@edzer
Copy link
Member

edzer commented Apr 9, 2019

I guess GH is more foregiving about mistakes like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants