Candidate fix #117 #124
Merged
Candidate fix #117 #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why windows build is failing but it does not seem to be related to my change |
Enhance suggests deps Enhance news file Fix possible CRAN issues
|
Thanks so much! Without your help it might have taken me longer before I noticed the tests are disabled 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the candidate fix for the issue mentioned here #117 (comment)
It looks to be as simple as removing the statement that blocks the execution for R 4.1.x and above. Additionally, I added a decor package to suggests dependencies. My tests on the fresh R installation (MacOS) showed that
decoris required bycpp11which is required byroxygen2for the execution of unit tests embedded in this package. Therefore I think it's appropriate to add it as a dependency so it can be tested in a fresh installation. This is just a suggestion, I'm happy to remove that one.Requesting review @lionel-