Skip to content

Commit

Permalink
Remove CXX_STD = CXX11
Browse files Browse the repository at this point in the history
Mainly prompted to do so by CRAN, but since all modern versions of R require at least C++11 nowadays, this should work fine
  • Loading branch information
DavisVaughan committed May 12, 2023
1 parent ab8a07d commit a1ed5c0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
6 changes: 3 additions & 3 deletions src/Makevars
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# CXX11 is required, apparently CXX14 would be better for constexpr support
# We no longer specify `CXX_STD = CXX11` since modern versions of R require
# C++11 as a minimum. This also allows more modern compilers to use C++14, which
# has constexpr benefits.

# -DINSTALL=dummy
# To keep some problematic code from running on windows if INSTALL isn't defined.
Expand All @@ -24,8 +26,6 @@
# Because of these issues, we instead default to using an uncompressed
# text version of the database that we ship with tzdb.

CXX_STD = CXX11

PKG_CXXFLAGS = \
-I../inst/include \
-DINSTALL=dummy \
Expand Down
2 changes: 0 additions & 2 deletions src/Makevars.win
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
CXX_STD = CXX11

# https://howardhinnant.github.io/date/tz.html
# "mingw users: -lpthread and -lole32 are required."
PKG_LIBS = \
Expand Down

0 comments on commit a1ed5c0

Please sign in to comment.