Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter alignemnt detection for unequal number of tokens on different lines #903

Merged
merged 6 commits into from
Jan 16, 2022

Conversation

lorenzwalthert
Copy link
Collaborator

@lorenzwalthert lorenzwalthert commented Jan 15, 2022

Closes #901. We first fix a bug that counted , twice when calculating the column value. This was irrelevant so far because it acted like an offset that affected all values. Also towards #258.

@lorenzwalthert lorenzwalthert marked this pull request as draft January 15, 2022 22:00
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2022

Codecov Report

Merging #903 (3d33d16) into main (10b064b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #903      +/-   ##
==========================================
+ Coverage   90.33%   90.35%   +0.01%     
==========================================
  Files          47       47              
  Lines        2546     2551       +5     
==========================================
+ Hits         2300     2305       +5     
  Misses        246      246              
Impacted Files Coverage Δ
R/detect-alignment.R 97.46% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10b064b...3d33d16. Read the comment docs.

This needs refactoring
@lorenzwalthert lorenzwalthert marked this pull request as ready for review January 15, 2022 23:41
@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 1695b96 is merged into main:

  •   :ballot_box_with_check:cache_applying: 23.2ms -> 23.2ms [-0.79%, +0.52%]
  •   :ballot_box_with_check:cache_recording: 972ms -> 972ms [-0.4%, +0.55%]
  •   :ballot_box_with_check:without_cache: 2.59s -> 2.58s [-0.95%, +0.08%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@lorenzwalthert lorenzwalthert merged commit 38dc65a into r-lib:main Jan 16, 2022
@lorenzwalthert lorenzwalthert deleted the issue-901 branch January 16, 2022 11:31
@github-actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if e7ad5f7 is merged into main:

  •   :ballot_box_with_check:cache_applying: 22.5ms -> 22.7ms [-0.82%, +2.48%]
  • ❗🐌cache_recording: 979ms -> 1.01s [+0.5%, +5.08%]
  •   :ballot_box_with_check:without_cache: 2.71s -> 2.66s [-3.97%, +0.54%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have only a single space character between elements and their separators?
2 participants