-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to lorenzwalthert/touchstone #698
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #698 +/- ##
==========================================
- Coverage 90.42% 90.41% -0.01%
==========================================
Files 47 47
Lines 2225 2223 -2
==========================================
- Hits 2012 2010 -2
Misses 213 213
Continue to review full report at Codecov.
|
This reverts commit 55394ca.
…ion, see ?bench::mark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the continuous benchmarking infrastructure provided by r-lib/bench with the touchstone package. Key insights were:
From https://github.com/lorenzwalthert/touchstone.
First results with 20 iterations are promising and take about 30 minutes. They show 0% difference in median for this PR, which was expected as no code that is benchmarked changes. Second run: 0.9%, third run 3%, fourth -0.1%. Results can be found under the GitHub Action -> Artifacts.
Here is the comparison of 20 iterations with 20 times
style_pkg()
for thehere
package for master and touchstone branch.