make R.cache an import #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #589 +/- ##
==========================================
+ Coverage 91.53% 92.12% +0.58%
==========================================
Files 47 47
Lines 2115 2094 -21
==========================================
- Hits 1936 1929 -7
+ Misses 179 165 -14
Continue to review full report at Codecov.
|
lorenzwalthert
force-pushed
the
improve-caching
branch
2 times, most recently
from
ab1034e to
4e9ca34
Compare
… there is no R.cache premanent directory, the user is never asked about setting up a permanent directory.
This remove one step in the styler setup for caching. Now, the only thing an interactive user has to do is to allow R.cache to set up a permanent cache. I believe this is worth the three extra recursive dependencies because there is actually no reason why you are strictly against using caching, even on CI/CD it will speed up things.
lorenzwalthert
force-pushed
the
improve-caching
branch
from
7bf9bd1 to
825a4ad
Compare
lorenzwalthert
changed the title
|
Also relevant link: #578. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that when cache is was deactivated by the user and R.cache is installed but there is no R.cache permanent directory, the user is never asked about setting up a permanent directory.