Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap long lines (follow up) #496

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Wrap long lines (follow up) #496

wants to merge 5 commits into from

Conversation

lorenzwalthert
Copy link
Collaborator

Follow-up of #414.

@lorenzwalthert lorenzwalthert mentioned this pull request Mar 21, 2020
@lorenzwalthert
Copy link
Collaborator Author

Status of this PR:

  • worked at some point but not for all cases I experimented with.
  • probably there are merge conflicts by now, has to be rebased on master. I think this PR is conceptually a good approach, but the implementation may need substantial rework.
  • After the experience with caching and stylerignore feature in v1.3.0, I think we should make this an opt-in feature governed by an R option for a few releases. Also, styler will be slower when this is turned on.
  • as this is considered to be invasive, it should only take effect for strict = TRUE.
  • Not sure if we should takle the problem for different expression types individually instead of aiming for a general solution. Prime candidate: function calls. I think the overwhelming majority of long lines are function calls (potentially nested in assignment expressions). Related: Enforce line break after + in ggplot2 #544.

I am not going to contribute code to this feature soon though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants