Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove S4 class after test #1564

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Remove S4 class after test #1564

merged 1 commit into from
Jan 3, 2024

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Jan 2, 2024 •
edited
Loading

@krlmlr krlmlr requested a review from hadley January 2, 2024 20:24
@hadley hadley merged commit 85653bc into r-lib:main Jan 3, 2024
12 checks passed
@hadley
Copy link
Member

hadley commented Jan 3, 2024

Thanks!

@krlmlr krlmlr deleted the b-remove-s4 branch January 3, 2024 04:42
@krlmlr krlmlr mentioned this pull request Jan 3, 2024
Merged
@krlmlr
Copy link
Member Author

krlmlr commented Jan 3, 2024

It's no good, I reverted in 1382f7d.

This was referenced Jan 3, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley Awaiting requested review from hadley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krlmlr @hadley