-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow overriding default knitr chunk options #1390
Conversation
What about reading from What do you think the scope should be for the options? A single |
IDK, it just seems simpler to specify the defaults in the config, and then use them in the whole package. So I think the scope should be the whole package, for simplicity. |
Yeah, that makes sense. Can you also add a few words to the |
Otherwise it messes up the options of the current process.
@hadley all done, I believe. We need to run the test in a subprocess, unfortunately, because it messed up the roxygen pptions we rely on in other test cases. Alternatively we could add a |
Maybe we should have a |
- Make sure line endings are the same on all platforms. - Also test overriding the defaults.
To deal with the different line endings. [ci skip]
I think this would be useful to avoid repetition. I can try to write some test case.
Potentially fixes #1240