fix sxp error message #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Oct 30, 2023
R/sxp.R
Outdated
| } | ||
|
|
||
| obj_inspect_(x, | ||
| obj_inspect_( |
There was a problem hiding this comment.
Would you mind not restyling in this PR? It's better to fix code style in a separate PR so it's easy to focus on the substantive changes.
There was a problem hiding this comment.
Yes I thought the same thing after I saw it on github - I'll fix it and add a test.
There was a problem hiding this comment.
@hadley I have added the test and removed the restyling (format on save was the culprit!). Hope this does the job now - if not let me know.
This reverts commit 8075ab4.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to solve this issue with the error message for the
lobstr::sxp()function.