New pipe_call_linter enforcing calls (not symbols) in magrittr pipes

[MichaelChirico]

This enforces the following section of the tidyverse style guide:

https://style.tidyverse.org/pipes.html#no-arguments

[AshesITR]

Looks good so far. Can we also add a negative test for

x %>% { foo }

just to be sure symbols are allowed in curly braces?

[MichaelChirico]

does that code actually do anything?

…

On Wed, May 19, 2021, 1:05 PM AshesITR ***@***.***> wrote: Looks good so far. Can we also add a negative test for x %>% { foo } just to be sure symbols are allowed in curly braces? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#801 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB2BA5IOSGGGMA64XNIOGS3TOQKYLANCNFSM45D7LYKQ> .

[AshesITR]

This minimal code returns foo from the chain.
However, if this is correctly not linted, more complex code blocks should also be covered - e.g.

x %>% {
  tmp <- .
  bla <- foo %>% unrelated_stuff(tmp)
  my_combination_fun(tmp, bla)
}

[MichaelChirico]

that looks more reasonable to test as a minimal usage example. I'll test & add it tomorrow.

…

On Thu, May 20, 2021, 1:50 AM AshesITR ***@***.***> wrote: This minimal code returns foo from the chain. However, if this is correctly not linted, more complex code blocks should also be covered - e.g. x %>% { tmp <- . bla <- foo %>% unrelated_stuff(tmp) my_combination_fun(tmp, bla) } — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#801 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB2BA5PXAPVKEPRVQCZENFLTOTEMFANCNFSM45D7LYKQ> .

[MichaelChirico]

Updated now. Thanks!