Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround for roxygen2 bug #2515

Closed
wants to merge 2 commits into from
Closed

Conversation

MichaelChirico
Copy link
Collaborator

See #2510, r-lib/roxygen2#1572.

This workaround fits the full @rawNamespace directive on one line, thus impervious to the sort() issue.

We can revert this to the more readable version either at release or when {roxygen2} releases again, but for now it's causing some of our CI tests to fail e.g.

https://github.com/r-lib/lintr/actions/runs/7607480388/job/20714878154?pr=2514

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bad1632) 98.55% compared to head (f53e791) 98.55%.

❗ Current head f53e791 differs from pull request most recent head a68edbd. Consider uploading reports for the commit a68edbd to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2515   +/-   ##
=======================================
  Coverage   98.55%   98.55%           
=======================================
  Files         126      126           
  Lines        5762     5762           
=======================================
  Hits         5679     5679           
  Misses         83       83           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelChirico
Copy link
Collaborator Author

{roxygen2} published to CRAN already, this PR obsolete.

@MichaelChirico MichaelChirico deleted the MichaelChirico-patch-1 branch January 23, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants