New terminal_close_linter

[MichaelChirico]

Part of #884

We might consider renaming this to just close_linter(), to flexibility in the future for more lints associated with use of close(). E.g., we might make this stricter by default and require all close() calls to be inside on.exit() hooks.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a1e2f1f) 99.63% compared to head (435299f) 99.63%.

❗ Current head 435299f differs from pull request most recent head bf2efc1. Consider uploading reports for the commit bf2efc1 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2276   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files         114      114           
  Lines        5258     5258           
=======================================
  Hits         5239     5239           
  Misses         19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[AshesITR]

Is this vectorized to detect multiple (trailing) close() calls? Should it be?

[MichaelChirico]

Is this vectorized to detect multiple (trailing) close() calls? Should it be?

Not now... can't say I've encountered that either. I would reserve for a follow-up if needed.

[AshesITR]

All right. Can we add a metadata test here as well? Maybe with an example containing two close statements to show which one lints?

[MichaelChirico]

All right. Can we add a metadata test here as well? Maybe with an example containing two close statements to show which one lints?

SG. Any opinion on terminal_close_linter() vs. close_linter()?

[AshesITR]

Hmm not sure where this might go. I can imagine a connection_linter() requiring on.exit(close(...)) immediately after any connection-opening code unless the connection is returned by the function.

My gut feeling says let's keep the name for now and see to deprecating / renaming if and when the need arises.