Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ubiquitously-called internal functions to NAMESPACE #2031

Merged
merged 22 commits into from
Aug 7, 2023
Merged

Conversation

MichaelChirico
Copy link
Collaborator

Split off from #2030 for clarity.

These calls are used so much it's odd we wouldn't put them in the NAMESPACE. After that, it's redundant IMO to always namespace-qualify them.

@AshesITR
Copy link
Collaborator

AshesITR commented Aug 2, 2023

There are some stray diffs in .Rd files here.

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2023

Codecov Report

Merging #2031 (c35bb57) into main (4e4183f) will increase coverage by 0.00%.
The diff coverage is 99.67%.

❗ Current head c35bb57 differs from pull request most recent head 14b432e. Consider uploading reports for the commit 14b432e to get more accurate results

@@           Coverage Diff           @@
##             main    #2031   +/-   ##
=======================================
  Coverage   98.56%   98.56%           
=======================================
  Files         114      114           
  Lines        5008     5017    +9     
=======================================
+ Hits         4936     4945    +9     
  Misses         72       72           
Files Changed Coverage Δ
R/utils.R 98.29% <90.90%> (ø)
R/T_and_F_symbol_linter.R 100.00% <100.00%> (ø)
R/any_duplicated_linter.R 100.00% <100.00%> (ø)
R/any_is_na_linter.R 100.00% <100.00%> (ø)
R/assignment_linter.R 100.00% <100.00%> (ø)
R/backport_linter.R 100.00% <100.00%> (ø)
R/boolean_arithmetic_linter.R 100.00% <100.00%> (ø)
R/brace_linter.R 100.00% <100.00%> (ø)
R/class_equals_linter.R 100.00% <100.00%> (ø)
R/commas_linter.R 100.00% <100.00%> (ø)
... and 79 more

R/indentation_linter.R Outdated Show resolved Hide resolved
R/indentation_linter.R Outdated Show resolved Hide resolved
R/paste_linter.R Outdated Show resolved Hide resolved
R/lintr-package.R Outdated Show resolved Hide resolved
@AshesITR
Copy link
Collaborator

AshesITR commented Aug 4, 2023

I've checked all changes. LGTM except for the unnecessary namespace imports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants