-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ubiquitously-called internal functions to NAMESPACE #2031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some stray diffs in .Rd files here. |
Codecov Report
@@ Coverage Diff @@
## main #2031 +/- ##
=======================================
Coverage 98.56% 98.56%
=======================================
Files 114 114
Lines 5008 5017 +9
=======================================
+ Hits 4936 4945 +9
Misses 72 72
|
AshesITR
reviewed
Aug 2, 2023
I've checked all changes. LGTM except for the unnecessary namespace imports. |
AshesITR
approved these changes
Aug 7, 2023
This was referenced Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off from #2030 for clarity.
These calls are used so much it's odd we wouldn't put them in the NAMESPACE. After that, it's redundant IMO to always namespace-qualify them.