Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New redundant_equals_linter #1556

Merged
merged 11 commits into from
Sep 28, 2022
Merged

New redundant_equals_linter #1556

merged 11 commits into from
Sep 28, 2022

Conversation

MichaelChirico
Copy link
Collaborator

Part of #884; Closes #1500.

Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nitpicks. But, overall, looks good to me! :)

R/redundant_equals_linter.R Outdated Show resolved Hide resolved
R/redundant_equals_linter.R Outdated Show resolved Hide resolved
R/redundant_equals_linter.R Show resolved Hide resolved
tests/testthat/test-redundant_equals_linter.R Outdated Show resolved Hide resolved
tests/testthat/test-redundant_equals_linter.R Outdated Show resolved Hide resolved
@IndrajeetPatil IndrajeetPatil self-requested a review September 25, 2022 18:02
Copy link
Collaborator

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New linter for if(x == TRUE) and if(x == FALSE)
2 participants