Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove false positive in non-portable path linter #1452

Closed
wants to merge 9 commits into from
Closed

Remove false positive in non-portable path linter #1452

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3552a41
Add a failing test first
IndrajeetPatil Jul 16, 2022
7225de4
Merge branch 'main' into 1356_portable_false_positive
IndrajeetPatil Jul 19, 2022
e0e99b6
Merge branch 'main' into 1356_portable_false_positive
IndrajeetPatil Jul 26, 2022
35a0fef
Merge branch 'main' into 1356_portable_false_positive
IndrajeetPatil Jul 27, 2022
3406c1f
Merge branch 'main' into 1356_portable_false_positive
IndrajeetPatil Jul 27, 2022
36cb95c
Merge branch 'main' into 1356_portable_false_positive
IndrajeetPatil Aug 9, 2022
1e88e09
Merge branch 'main' into 1356_portable_false_positive
IndrajeetPatil Aug 24, 2022
81d8fba
Merge branch 'main' into 1356_portable_false_positive
IndrajeetPatil Aug 24, 2022
e6948e5
Merge branch 'main' into 1356_portable_false_positive
IndrajeetPatil Sep 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/testthat/test-nonportable_path_linter.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,11 @@ test_that("Non-portable path linter", {
expect_lint(single_quote(path), NULL, linter)
expect_lint(double_quote(path), NULL, linter)
}

# #1356
expect_lint(
"grepl('[a/b] c', x, fixed = TRUE)",
NULL,
linter
)
})