Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add update-rtools option #296

Merged
merged 1 commit into from
May 24, 2021
Merged

add update-rtools option #296

merged 1 commit into from
May 24, 2021

Conversation

jeroen
Copy link
Member

@jeroen jeroen commented May 9, 2021

@ijlyttle @yutannihilation @clauswilke this should fix your immediate issue with rust.

Introduces an option to update rtools to the latest builds of gcc and libraries. This is mainly useful for the preinstalled rtools40 installations on the GHA image.

@jimhester
Copy link
Member

If this option is set then we would not need to also download and install rtools separately right? Since the only time you would use this would be updating the rtools now included in the default image

@jeroen
Copy link
Member Author

jeroen commented May 10, 2021

In practice we never need to download and install rtools because it is always preinstalled.

But even when we would, it can still be useful to update it because the installer on CRAN gets updated rarely because changing the sha256 breaks tools like chocolatey which check for integrity.

@yutannihilation
Copy link
Contributor

Thanks for this, Jeroen!

@ijlyttle @yutannihilation @clauswilke this should fix your immediate issue with rust.

Btw, maybe you mistyped @Ilia-Kosenkov?

@jimhester jimhester merged commit 5aa20dd into r-lib:master May 24, 2021
@jimhester
Copy link
Member

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants