Skip to content

Commit

Permalink
test-coverage: try not to fail on failing uploads for PRs
Browse files Browse the repository at this point in the history
[ci skip]
  • Loading branch information
gaborcsardi committed May 8, 2024
1 parent a1c1152 commit 76c974b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test-coverage.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:

- uses: codecov/codecov-action@f1b7348826d750ac29741abc9d1623d8da5dcd4f
with:
fail_ci_if_error: ${{ github.event_name != 'pull_request' }}
fail_ci_if_error: ${{ github.event_name != 'pull_request' && true || false }}

This comment has been minimized.

Copy link
@krlmlr

krlmlr Aug 6, 2024

Member

Could we change this to fail only if ${{ secrets.CODECOV_TOKEN }} is missing?

This comment has been minimized.

Copy link
@gaborcsardi

gaborcsardi Aug 6, 2024

Author Member

Sure, a PR is welcome.

file: ./cobertura.xml
plugin: noop
disable_search: true
Expand Down
2 changes: 1 addition & 1 deletion examples/test-coverage.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:

- uses: codecov/codecov-action@v4
with:
fail_ci_if_error: ${{ github.event_name != 'pull_request' }}
fail_ci_if_error: ${{ github.event_name != 'pull_request' && true || false }}
file: ./cobertura.xml
plugin: noop
disable_search: true
Expand Down

0 comments on commit 76c974b

Please sign in to comment.