-
Notifications
You must be signed in to change notification settings - Fork 13
Images also need pandoc #10
Comments
But from the log is looks pandoc, knitr and rmarkdown are all getting installed, and it still gives the warning. |
@jeroenooms Oh, indeed. |
The build fails due to an |
From https://github.com/yihui/knitr/blob/9394e12b764c9729368200a04dae770c098ab808/R/utils-vignettes.R#L8-L24 it needs |
I think |
Or do you think we should always install |
@gaborcsardi I think you are probably correct, pandoc-citeproc should probably be in |
OK, I think we'll just install |
Crossposting here: yihui/knitr#1286 |
@jeroenooms wait, so the missing |
I think in this case it is, but I am seeing this problem locally as well sometimes (and I have both...) |
Did you make |
Not the default image, but I'll just install But this is not done yet, something in sysreqs does not handle package On Tue, Sep 6, 2016 at 4:42 PM, Jeroen Ooms [email protected]
|
It should be OK now, pandoc and pandoc-citeproc go together. |
Btw. these links are not very good on GitHub, because they are removed after 3 days, I mean r-hub removed the builds.... just FYI.... |
Did you fix this yet? I'm still getting these warnings: https://builder.r-hub.io/status/curl_1.9000.tar.gz-9a07cdd4f9607723c5e9b8f135db8376 |
I did, but apparently EPEL does not have a |
Hmm you're right, it's in EPEL 7 but not EPEL 6: https://apps.fedoraproject.org/packages/pandoc-citeproc |
If it is available in some other repo, backported or sg., then I can add that repo. Or we need to compile it? Or download a binary from somewhere? |
Meh I think you'd have to install from source. Or we could host backports somewhere on a gh-pages branch or so.... |
It's not clear to me why we need citeproc in the first place for vignettes without citations. @yihui |
Just In case your vignettes have bibliography. |
Travis simply installs Pandoc from the .deb release, which includes pandoc-citeproc https://github.com/travis-ci/travis-build/blob/master/lib/travis/build/script/r.rb#L473 |
Yeah but centos 6 doesn't have that... |
You can (pre)build both pandoc and pandoc-citeproc as standalone binaries. |
I can build an rpm for it, and put it in a repo I suppose. No need to put these on GH pages, they will be fine on r-hub. |
@gaborcsardi did you end up creating a |
It is not just that. pandoc in centos6 is very old, that needs to be updated, too. So I am working out a way to do this. :/ Also, wch/r-source@74c8486 |
I'll install it from the RStudio binaries, and via a custom install specification in sysreqs (to be added). So no RPM, sorry..... |
OK, so I am downloading and installing pandoc from the RStudio-built binaries, and still have issues. :/ Fedora:
Ubuntu:
CentOS:
Debian is OK. |
@gaborcsardi Can you provide the Rmd file and your rmarkdown version? AFAIK we don't use any https resources in rmarkdown, so I don't know why Pandoc was trying to download resources from bootstrapcdn.com. |
@yihui It was the Btw. it needs libgmp and libffi on a stock Fedora 24 Docker container, it seems that the RPM versions assume old libs.
|
Okay, I'd recommend rchallenge either to localize font-awesome, or not to use the self-contained mode. It is a waste of time and resources to download a copy of font-awesome every time a document is compiled. I don't know how RStudio's pandoc was built, but I wonder if you have tried to build the binary by yourself. You only need to build it once, and the self-contained binary can be stored elsewhere (S3, Github releases, ...) and used later. I guess it is not that terrible. |
@jeroenooms pandoc RPMs for centos6: https://files.r-hub.io/pandoc/centos6/ |
@jeroenooms And if you want to see how they are built, or tweak: https://github.com/r-hub/pandoc-builders |
Yes, this would not be terrible, but unfortunately it is not true. It is hard to build a static binary, and the shared binary will depend on the system libs (libgmp in particular), so it won't be portable. E.g. RStudio's latest RPM binary does not work on Fedora 24, and the CentOS6 binary I built does not, either. So in practice, I'll need to build at least a couple of binaries. Anyway, I have an "easy" way of building them now, at least. |
@jeroenooms Updated (reverted) sysreqs, and updated centos6 images to install from our own repository: rhub-linux-builders/centos6-epel/Dockerfile Lines 9 to 11 in d09595f
It all works fine now. And you get the latest pandoc and pandoc-citeproc, with HTTPS support. |
CC @jeroenooms
Pandoc is in the
SystemRequirements
ofknitr
:https://github.com/cran/knitr/blob/e3adb6f1d7b1ed4ae9c016c015c88e5a237f1d3f/DESCRIPTION#L90-L93
We already have an entry for it in sysreqs DB:
https://github.com/r-hub/sysreqsdb/blob/master/sysreqs/pandoc.json
Maybe
Suggests
is not used for finding system requirements?The text was updated successfully, but these errors were encountered: