Make this library as an ESP IDF compatible component #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should have encountered this PR earlier. I have just finished the port of AutoPID to ESP-IDF. Then, I came across this PR request, which does the same thing three years ago. 😭 |
|
Sorry to hear that. But on the other hand my PR is already 3 years old and probably does not align very well with todays expectations for ESP-IDF components. So feel free to extend this PR or notify me if I should close this because you created a more up to date PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds preprocessor statements and replacement functions to make this library available as an ESP IDF compatible component which can easily be included in ESP IDF based projects.
Compatibility to the Arduino framework should be retained. This solved #14.