Implement RStudio Connection Contract

[edgararuiz-zz]

The Connection Contract integrates the RStudio IDE with the database connection. Here is the link with the details: https://rstudio.github.io/rstudio-extensions/connections-contract.html

[krlmlr]

Rather than implementing the contract in each DBI backend, how about implementing it in DBI itself? Something like

setGeneric("dbConnect",
  def = function(drv, ...) {
    con <- standardGeneric("dbConnect")
    register_con_with_rstudio(con)
    con
  },
  valueClass = "DBIConnection"
)

instead of the current implementation:

setGeneric("dbConnect",
  def = function(drv, ...) standardGeneric("dbConnect"),
  valueClass = "DBIConnection"
)

? The same for dbDisconnect(). To catch disconnects that happen through garbage collection, we could register a finalizer on the external pointer that lives in the connection.

@jimhester @javierluraschi @edgararuiz: Thoughts?

[edgararuiz-zz]

Yes! That's what I would rather have. It centralizes updates and it will give any new and existing DBI compliant immediate integration w the IDE!

[russellpierce]

What dependencies (if any) will this add to DBI or RMariaDB?

[edgararuiz-zz]

None that I can see, I checked the instructions (http://db.rstudio.com/advanced/contract) and odbc's implementation of the Contract: https://github.com/rstats-db/odbc/blob/5acc55350e0664002d6281f4659c089911fbd7c3/R/Viewer.R

[jimhester]

I would prefer having this in DBI as well. @jmcphers would probably be the person to consult about what changes were necessary in DBI to get this working for all compliant backends.

[nwstephens]

I would love to see the connection contract implemented in DBI. What's the status on this? @krlmlr

[krlmlr]

Will look at it in December. In the meantime, happy to review ideas/PRs in the DBI package ;-)

[jtelleriar]

Thank you to you for your great work with RMariaDB. Juan El 14/11/2017 8:54 a. m., "Kirill Müller" <[email protected]> escribió: Will look at it in December. In the meantime, happy to review ideas/PRs in the DBI package ;-) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#55 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AcHLJ_FeRQWcliCW2mtGPzB4IbFw9Nnjks5s2UcdgaJpZM4PNXZX> .

[edgararuiz-zz]

@krlmlr - I started working on the contract, and what I have so far works well for DBs that have no schemata. For databases with more than one schema, dbListTables() does not provide enough data to create a tree that the user can drill into (db-schema-table/view), and there's no dbListSchemas() command available. We could implement something w/o displaying the schema, but that will mean that the user will not know which schema to use when the try to call it via dbGetQuery() for example. Thoughts?

cc @nwstephens

[krlmlr]

@edgararuiz: Schema support is pending (r-dbi/DBI#24), I'll tackle it later in December. Would you mind sharing your current implementation so that we can discuss there?

[edgararuiz-zz]

@krlmlr - Sounds good, here's the link to the Gist: https://gist.github.com/edgararuiz/0533b3daf70a41b70acd75c1e6a2b7a3

It is essentially a simplified version of the odbc's package contract: https://github.com/r-dbi/odbc/blob/master/R/Viewer.R

[edgararuiz-zz]

@krlmlr - as an aside, what are the plans for other DB elements, like enumerating databases inside a server? Ideally, we should be able to list databases inside a server, schemata inside a database, tables/views inside a schema. Also, are the plans to add more metadata to dbListTables() so we can see differentiate between tables and views?

[krlmlr]

@edgararuiz: We should be able to support most of what you're suggesting, please see #24 for details.

Closing in favor of https://github.com/r-dbi/DBI/issues/211.

[github-actions]

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.