Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test return values and error conditions #31

Closed
22 of 25 tasks
krlmlr opened this issue Nov 12, 2015 · 2 comments
Closed
22 of 25 tasks

Test return values and error conditions #31

krlmlr opened this issue Nov 12, 2015 · 2 comments
Milestone
2

Comments

@krlmlr
Copy link
Member

krlmlr commented Nov 12, 2015 •
edited
Loading

  • dbBind(): input result (invisibly)
  • dbClearResult(): TRUE
  • dbColumnInfo(): a data frame with three columns (Think about columns in dbColumnInfo() output DBI#78)
  • dbConnect()
  • dbDataType()
  • dbDisconnect(): TRUE
  • dbExistsTable(): logical
    • scalar input
  • dbFetch(): a data frame
    • scalar input
  • dbGetInfo(): a named list
  • dbExecute()
    • scalar input
  • dbGetQuery()
    • scalar input
  • dbGetRowCount(): an integer
  • dbGetRowsAffected(): an integer
  • dbGetStatement(): a character
  • dbHasCompleted(): TRUE
  • dbIsValid(): TRUE
  • dbListTables(): a character vector
  • dbListFields()
    • scalar input
  • dbQuoteIdentifier(): a classed object (of class "SQL")
  • dbQuoteString(): a classed object (of class "SQL")
  • dbReadTable(): a data frame
    • scalar input
  • dbRemoveTable(): TRUE
    • scalar input
  • dbSendQuery()
    • scalar input
  • dbSendStatement()
    • scalar input
  • dbWriteTable(): TRUE
    • scalar input

Combine with error testing, in particular invalid arguments
@krlmlr krlmlr added this to the 1.0 milestone Nov 12, 2015
@krlmlr krlmlr changed the title Test return values Test return values and error conditions Nov 13, 2015
@krlmlr
Copy link
Member Author

krlmlr commented Nov 13, 2015

Postponed.

@krlmlr krlmlr modified the milestones: bluesky, 1.0 Nov 13, 2015
krlmlr pushed a commit that referenced this issue Nov 13, 2015
Test return values and error conditions for dbBind() and `dbClearRe…
a72d335 
…sult()` (#31)

Merge branch 'feature/31-return-error' into develop
krlmlr pushed a commit that referenced this issue Nov 14, 2015
Merge tag 'v0.2-2' into develop
d338b14 
- Refactor `data_` tests to use a worker function `test_select()`
- Test tables with `NA` values above and below the non-`NA` value in `data_` tests
- Test return values and error conditions for `dbBind()` and `dbClearResult()` (#31)
- Test vectorization of `dbQuoteString()` and `dbQuoteIdentifier()` (#18)
- Test that dates have `integer` as underlying data type (#9)
- Roundtrip tests sort output table to be sure (#32)
- Avoid using `data.frame()` for date and time columns (#10)
- Use `expect_identical()` instead of `expect_equal()` in many places (#13)
@krlmlr krlmlr modified the milestones: bluesky, 1.1 Nov 15, 2015
krlmlr pushed a commit that referenced this issue Nov 15, 2015
Merge tag 'v0.3' into develop
2d6fa83 
- Feature-complete, ready for review
- Tests from the proposal
    - Add missing methods to compliance check
    - Add simple read-only test (#27)
    - Add stress tests for repeated load/unload (with and without connecting) in new R session (#2),
    - Migrate all tests from existing backends (#28)
    - Refactor `data_` tests to use a worker function `test_select()`
    - Test tables with `NA` values above and below the non-`NA` value in `data_` tests
    - Test return values and error conditions for `dbBind()` and `dbClearResult()` (#31)
    - Test vectorization of `dbQuoteString()` and `dbQuoteIdentifier()` (#18)
    - Test that dates have `integer` as underlying data type (#9)
    - Roundtrip tests sort output table to be sure (#32)
    - Test `NA` to `NULL` conversion in `dbQuoteString()`, and false friends (#23)
    - Enhance test for `dbQuoteIdentifier()` (#30)
- Style
    - Avoid using `data.frame()` for date and time columns (#10)
    - Use `expect_identical()` instead of `expect_equal()` in many places (#13)
    - Catch all errors in `on.exit()` handlers via `expect_error()` (#20).
    - Combine "meta" tests into new `test_meta()` (#37)
- Documentation
    - New "test" vignette (#16)
    - Add package documentation (#38)
- Same as 0.2-5
@krlmlr krlmlr mentioned this issue Jan 2, 2017
Closed
10 tasks
@krlmlr krlmlr added the ready label Apr 5, 2017
@krlmlr
Copy link
Member Author

krlmlr commented Apr 21, 2017

Will be done when specifying the remaining methods.

@krlmlr krlmlr closed this as completed Apr 21, 2017
@ghost ghost removed the ready label Apr 21, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2
Development

No branches or pull requests
1 participant
@krlmlr