Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Id() now accepts unnamed components #417

Merged
merged 5 commits into from
Nov 8, 2023
Merged

feat: Id() now accepts unnamed components #417

merged 5 commits into from
Nov 8, 2023

Conversation

hadley
Copy link
Member

@hadley hadley commented Nov 7, 2023

I think requiring names has little benefit — we never actually use them, never need to care about them, and requires a bunch of extra typing.

@hadley hadley requested a review from krlmlr November 7, 2023 13:45
@github-actions github-actions bot mentioned this pull request Nov 7, 2023
Closed
@hadley hadley mentioned this pull request Nov 7, 2023
Closed
@krlmlr krlmlr changed the title Remove requirement to name ID components feat: Id() now accepts unnamed components Nov 8, 2023
@aviator-app Aviator app
Copy link
Contributor

aviator-app bot commented Nov 8, 2023 •
edited
Loading

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

krlmlr
krlmlr reviewed Nov 8, 2023
View reviewed changes
Copy link
Member

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good idea.

R/00-Id.R Outdated Show resolved Hide resolved
R/dbQuoteIdentifier_DBIConnection.R Show resolved Hide resolved
@aviator-app aviator-app bot force-pushed the unnamed-id branch 2 times, most recently from af7e405 to 8727aa7 Compare November 8, 2023 11:13
@krlmlr
Copy link
Member

krlmlr commented Nov 8, 2023

Thanks!

@hadley
Copy link
Member Author

hadley commented Nov 8, 2023

I assume this somehow gets turn into an automatic news bullet?

@aviator-app aviator-app bot added the blocked label Nov 8, 2023
@aviator-app Aviator app
Copy link
Contributor

aviator-app bot commented Nov 8, 2023

This pull request failed to merge: PR cannot be automatically rebased, please rebase manually to continue. Remove the blocked label to re-queue.

Additional debug info: Failed to rebase this PR onto the latest changes from the base branch. You will probably need to rebase this PR manually and resolve conflicts).

@krlmlr krlmlr removed the blocked label Nov 8, 2023
@krlmlr
Copy link
Member

krlmlr commented Nov 8, 2023

Yes, taken from the PR title, with contributor (if not in DESCRIPTION) and links to PR and issue (if relevant).

@aviator-app aviator-app bot merged commit 9b88962 into main Nov 8, 2023
26 checks passed
@aviator-app aviator-app bot deleted the unnamed-id branch November 8, 2023 18:14
@dpprdan dpprdan mentioned this pull request Dec 20, 2023
Closed
dpprdan added a commit to dpprdan/RPostgres that referenced this pull request Dec 21, 2023
@dpprdan
allow quoting of unnamed Id() components
6daebc7 
re r-dbi/DBI#417
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krlmlr krlmlr krlmlr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hadley @krlmlr